Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inbound queue #750

Merged
merged 10 commits into from
Nov 27, 2024
Merged

Add inbound queue #750

merged 10 commits into from
Nov 27, 2024

Conversation

ParthDesai
Copy link
Contributor

@ParthDesai ParthDesai commented Nov 18, 2024

Description

This PR adds inbound queue to starlight and include tests for the same.

It adds message processor called SymbioticMessageProcessor which upon receiving new validators, calls ExternalValidators pallet to set the validators.

What is remaining?

  • Benchmarking

Note

The base of the PR is at tomasz-generic-aggregate-message-origin since this PR is dependent upon code introduced there.
Base changed to master after PR merge.

Copy link
Contributor

github-actions bot commented Nov 18, 2024

WASM runtime size check:

Compared to target branch

dancebox runtime: 1424 KB (no changes) ✅

flashbox runtime: 820 KB (no changes) ✅

dancelight runtime: 2104 KB (no changes) ✅

container chain template simple runtime: 1124 KB (no changes) ✅

container chain template frontier runtime: 1400 KB (no changes) ✅

@ParthDesai ParthDesai changed the title [WIP] Add inbound queue + tests [WIP] Add inbound queue Nov 18, 2024
Copy link
Contributor

github-actions bot commented Nov 20, 2024

Coverage Report

(master)

@@                 Coverage Diff                  @@
##           master   add-inbound-queue     +/-   ##
====================================================
  Coverage   64.57%              64.57%   0.00%     
+ Files         317                 320      +3     
+ Lines       55357               55407     +50     
====================================================
+ Hits        35745               35777     +32     
+ Misses      19612               19630     +18     
Files Changed Coverage
/solo-chains/runtime/dancelight/src/lib.rs 66.21% (+0.02%)

Coverage generated Wed Nov 27 15:54:02 UTC 2024

@ParthDesai ParthDesai force-pushed the add-inbound-queue branch 4 times, most recently from fff9fdc to 3eba4a5 Compare November 25, 2024 15:14
@ParthDesai ParthDesai changed the title [WIP] Add inbound queue Add inbound queue Nov 25, 2024
@ParthDesai ParthDesai force-pushed the add-inbound-queue branch 2 times, most recently from d2b0917 to 33b0d32 Compare November 26, 2024 11:28
Base automatically changed from tomasz-generic-aggregate-message-origin to master November 26, 2024 12:20
@ParthDesai ParthDesai marked this pull request as ready for review November 26, 2024 12:27
Cargo.toml Outdated Show resolved Hide resolved
Copy link
Collaborator

@girazoki girazoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but I have an important question and minor comments. Specially in the inbound delivery cost

@girazoki girazoki added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Nov 26, 2024
@ParthDesai ParthDesai added the breaking Needs to be mentioned in breaking changes label Nov 27, 2024
@ParthDesai ParthDesai merged commit 62053be into master Nov 27, 2024
42 checks passed
@ParthDesai ParthDesai deleted the add-inbound-queue branch November 27, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants