-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Container candidates in dev service #747
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
girazoki
changed the title
Girazoki dev service comp
Container candidates in dev service
Nov 15, 2024
girazoki
added
B0-silent
Changes should not be mentioned in any release notes
not-breaking
Does not need to be mentioned in breaking changes
D3-trivial
PR contains trivial changes in a runtime directory that do not require an audit
labels
Nov 15, 2024
WASM runtime size check:Compared to target branchdancebox runtime: 1412 KB (no changes) ✅ flashbox runtime: 832 KB (no changes) ✅ dancelight runtime: 2008 KB (+2008 KB) container chain template simple runtime: 1088 KB (-4224 KB) ✅ container chain template frontier runtime: 1388 KB (-5136 KB) ✅ |
Coverage Report@@ Coverage Diff @@
## master girazoki-dev-service-comp +/- ##
=============================================================
+ Coverage 65.33% 65.47% +0.14%
+ Files 311 312 +1
+ Lines 54198 54503 +305
=============================================================
+ Hits 35407 35685 +278
+ Misses 18791 18818 +27
|
tmpolaczyk
reviewed
Nov 19, 2024
tmpolaczyk
reviewed
Nov 19, 2024
tmpolaczyk
reviewed
Nov 19, 2024
tmpolaczyk
reviewed
Nov 20, 2024
tmpolaczyk
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
B0-silent
Changes should not be mentioned in any release notes
D3-trivial
PR contains trivial changes in a runtime directory that do not require an audit
not-breaking
Does not need to be mentioned in breaking changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to inject container candidates on dancelights dev service. For now this remains as an opt-in that you can enable in your tests by calling the following rpc in dev mode:
mock_enableParaInherentCandidate
similarly you can disable it by calling:
mock_disableParaInherentCandidate
I also added a test that proves that when enabled, this mode makes the para-head progress in the relay, indicating the candidates are being inserted.
TODO in this PR:
Follow-up tests for future PRs would be: