Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starlight: add smoke test for BEEFY and MMR digests #745

Merged
merged 6 commits into from
Nov 15, 2024

Conversation

Agusrodri
Copy link
Contributor

This PR adds a smoke test which checks that both BEEFY and MMR root digests are correct and consistent.

@Agusrodri Agusrodri added B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime/client code not-breaking Does not need to be mentioned in breaking changes labels Nov 14, 2024
Copy link
Contributor

github-actions bot commented Nov 14, 2024

WASM runtime size check:

Compared to target branch

dancebox runtime: 1412 KB (no changes) ✅

flashbox runtime: 832 KB (no changes) ✅

dancelight runtime: 2008 KB (no changes) ✅

container chain template simple runtime: 1088 KB (no changes) ✅

container chain template frontier runtime: 1388 KB (no changes) ✅

Copy link
Contributor

github-actions bot commented Nov 14, 2024

Coverage Report

(master)

@@                     Coverage Diff                     @@
##           master   agustin-smoke-test-beefy     +/-   ##
===========================================================
  Coverage   65.34%                     65.34%   0.00%     
  Files         310                        310             
  Lines       54174                      54174             
===========================================================
  Hits        35395                      35395             
  Misses      18779                      18779             
Files Changed Coverage

Coverage generated Fri Nov 15 11:51:03 UTC 2024

Copy link
Collaborator

@girazoki girazoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job @Agusrodri

@Agusrodri Agusrodri merged commit ce21610 into master Nov 15, 2024
42 checks passed
@Agusrodri Agusrodri deleted the agustin-smoke-test-beefy branch November 15, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime/client code not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants