Check that para id has been reserved #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report@@ Coverage Diff @@
## master tomasz-register-reserve-para-id +/- ##
===================================================================
+ Coverage 64.94% 64.97% +0.03%
Files 296 296
+ Lines 51776 51817 +41
===================================================================
+ Hits 33625 33666 +41
Misses 18151 18151
|
tmpolaczyk
added
B7-runtimenoteworthy
girazoki
reviewed
Oct 4, 2024
girazoki
reviewed
Oct 4, 2024
test/suites/dev-tanssi-relay/pallet-data-preservers/test_pallet_data_preservers.ts
Show resolved
Hide resolved
girazoki
approved these changes
Oct 4, 2024
Agusrodri
approved these changes
Oct 12, 2024
WASM runtime size check:Compared to target branchdancebox runtime: 1412 KB (no changes) ✅ flashbox runtime: 824 KB (no changes) ✅ dancelight runtime: 1820 KB (no changes) ✅ container chain template simple runtime: 1096 KB (no changes) ✅ container chain template frontier runtime: 1392 KB (no changes) ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently anyone can register any para id in Stagelight. With this PR we add a check for
Registrar::reserve, so accounts will only be able to register para ids that they have previously reserved.