Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs related to altair > Solochain #712

Merged
merged 8 commits into from
Oct 14, 2024
Merged

docs related to altair > Solochain #712

merged 8 commits into from
Oct 14, 2024

Conversation

girazoki
Copy link
Collaborator

@girazoki girazoki commented Oct 2, 2024 •
edited
Loading

Adds docs related to altair to starlight comm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024 •
edited
Loading

Coverage Report

(master)

@@                      Coverage Diff                       @@
##           master   girazoki-add-altair-diagram     +/-   ##
==============================================================
  Coverage   64.97%                        64.97%   0.00%     
  Files         296                           296             
  Lines       51742                         51742             
==============================================================
  Hits        33615                         33615             
  Misses      18127                         18127
Files Changed Coverage

Coverage generated Mon Oct 14 08:44:41 UTC 2024

@girazoki girazoki added D3-trivial PR contains trivial changes in a runtime directory that do not require an audit B0-silent Changes should not be mentioned in any release notes not-breaking Does not need to be mentioned in breaking changes labels Oct 3, 2024
@girazoki girazoki requested a review from 0xvgg October 4, 2024 09:57
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 11, 2024 •
edited
Loading

WASM runtime size check:

Compared to target branch

dancebox runtime: 1412 KB (no changes) ✅

flashbox runtime: 824 KB (no changes) ✅

dancelight runtime: 1816 KB (+1816 KB) ⚠️

container chain template simple runtime: 1096 KB (-4212 KB) ✅

container chain template frontier runtime: 1396 KB (-5124 KB) ✅

@0xvgg 0xvgg self-requested a review October 11, 2024 15:35
Agusrodri
Agusrodri approved these changes Oct 12, 2024
View reviewed changes
Copy link
Contributor

@Agusrodri Agusrodri left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Mostly minor spelling stuff.

solo-chains/docs/bridge/etbereum-to-solo-chain.md Outdated Show resolved Hide resolved
solo-chains/docs/bridge/etbereum-to-solo-chain.md Outdated Show resolved Hide resolved
solo-chains/docs/bridge/etbereum-to-solo-chain.md Outdated Show resolved Hide resolved
solo-chains/docs/bridge/etbereum-to-solo-chain.md Outdated Show resolved Hide resolved
solo-chains/docs/bridge/etbereum-to-solo-chain.md Outdated Show resolved Hide resolved
solo-chains/docs/bridge/etbereum-to-solo-chain.md Outdated Show resolved Hide resolved
solo-chains/docs/bridge/etbereum-to-solo-chain.md Outdated Show resolved Hide resolved
@girazoki girazoki merged commit 850fe6d into master Oct 14, 2024
41 checks passed
@girazoki girazoki deleted the girazoki-add-altair-diagram branch October 14, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ParthDesai ParthDesai ParthDesai left review comments

@0xvgg 0xvgg 0xvgg approved these changes

@Agusrodri Agusrodri Agusrodri approved these changes

Assignees
No one assigned
Labels
B0-silent Changes should not be mentioned in any release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@girazoki @ParthDesai @Agusrodri @0xvgg