Avoid ZeroCollators error in solochains #708
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In dancebox, the pallet_collator_assignment has a check to ensure that we never return an assignment with 0 collators, because that would brick the chain. But in dancelight, that's not a problem because validators are stored in another pallet. So we can safely handle the case of 0 collators, by returning an empty assignment.
So we will no longer see this log when starting a dancelight node:
Also add tests to ensure this doesn't panic.