Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved display of startup errors in node binaries #706

Merged

Conversation

chexware
Copy link
Contributor

@chexware chexware commented Oct 1, 2024

Added color_eyre to all node binary entry points for improved display of startup errors.

@chexware chexware added B0-silent Changes should not be mentioned in any release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes labels Oct 1, 2024
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Coverage Report

(master)

@@                                     Coverage Diff                                      @@
##           master   aleks-improve-display-of-startup-errors-in-node-binaries      +/-   ##
============================================================================================
+ Coverage   66.66%                                                     66.67%   +0.01%     
  Files         297                                                        297              
+ Lines       51824                                                      51830       +6     
============================================================================================
+ Hits        34548                                                      34554       +6     
  Misses      17276                                                      17276              
Files Changed Coverage

Coverage generated Tue Oct 1 15:43:02 UTC 2024

Copy link
Collaborator

@girazoki girazoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmpolaczyk tmpolaczyk merged commit b3e1c9c into master Oct 1, 2024
38 checks passed
@tmpolaczyk tmpolaczyk deleted the aleks-improve-display-of-startup-errors-in-node-binaries branch October 1, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants