-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved display of startup errors in node binaries #706
Merged
tmpolaczyk
merged 6 commits into
master
from
aleks-improve-display-of-startup-errors-in-node-binaries
Oct 1, 2024
Merged
Improved display of startup errors in node binaries #706
tmpolaczyk
merged 6 commits into
master
from
aleks-improve-display-of-startup-errors-in-node-binaries
Oct 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… display of startup errors
chexware
added
B0-silent
Changes should not be mentioned in any release notes
D3-trivial
PR contains trivial changes in a runtime directory that do not require an audit
not-breaking
Does not need to be mentioned in breaking changes
labels
Oct 1, 2024
Coverage Report@@ Coverage Diff @@
## master aleks-improve-display-of-startup-errors-in-node-binaries +/- ##
============================================================================================
+ Coverage 66.66% 66.67% +0.01%
Files 297 297
+ Lines 51824 51830 +6
============================================================================================
+ Hits 34548 34554 +6
Misses 17276 17276
|
girazoki
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tmpolaczyk
reviewed
Oct 1, 2024
tmpolaczyk
approved these changes
Oct 1, 2024
tmpolaczyk
deleted the
aleks-improve-display-of-startup-errors-in-node-binaries
branch
October 1, 2024 16:05
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
B0-silent
Changes should not be mentioned in any release notes
D3-trivial
PR contains trivial changes in a runtime directory that do not require an audit
not-breaking
Does not need to be mentioned in breaking changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
color_eyre
to all node binary entry points for improved display of startup errors.