-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorporate ts-tests to starlight #673
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report@@ Coverage Diff @@
## master girazoki-incorporate-tests-to-starlight +/- ##
===========================================================================
+ Coverage 67.48% 70.31% +2.83%
Files 264 264
+ Lines 47895 47946 +51
===========================================================================
+ Hits 32321 33711 +1390
- Misses 15574 14235 -1339
|
girazoki
added
B7-runtimenoteworthy
Changes should be noted in any runtime-upgrade release notes
D5-nicetohaveaudit⚠️
PR contains trivial changes to logic that should be properly reviewed.
breaking
Needs to be mentioned in breaking changes
labels
Sep 4, 2024
…e-tests-to-starlight
tmpolaczyk
reviewed
Sep 9, 2024
tmpolaczyk
approved these changes
Sep 9, 2024
Agusrodri
approved these changes
Sep 10, 2024
test/suites/common-all/fee_balance_transfer/test_fee_balance_transfer.ts
Show resolved
Hide resolved
Agusrodri
reviewed
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
B7-runtimenoteworthy
Changes should be noted in any runtime-upgrade release notes
breaking
Needs to be mentioned in breaking changes
D5-nicetohaveaudit⚠️
PR contains trivial changes to logic that should be properly reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a bunch of typescript tests to the starlight runtime which were missing. In general I took inspiration of those things that are already being tested in dancebox, so that involved the following test structure re-organization:
Additional changes to the starlight runtime:
I had to modify some parts of the genesis preconfiguration to include:
A relay-side registration when we inject container-chains, which involved mocking the head state. This works for dev tests (as we are doing nothing with the head-state) and worked with zombienet (because it overrides it). However a better way of handling this will be proposed in a separate PR.
Modification of pallet-treasury to only allow spends in the local native token.
Removal of some of the starlight pallets that were not playing any role: pallet-indices and pallet-recovery
Removal in starlight of the filter call to pallet-identity as the motivation for this was that the identity system chain which we dont have
TODOs for future PRs: