Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new tools for developers: testing a custom runtime upgrade against released binaries #671

Merged
merged 6 commits into from
Sep 5, 2024

Conversation

girazoki
Copy link
Collaborator

@girazoki girazoki commented Aug 29, 2024

Adds two new jobs to Moonwall, which dont execute in the CI, with the following purpose:

  • Download the latest released runtime, and create a chain-spec based of it
  • Download the latest release node, and start a network composed of relay + tanssi + a container with this node & the aforementioned generated specs
  • Perform a runtime upgrade against a locally built runtime

This job is similar to the one we have running in the CI, however this runs with the latest released node binaries, while the CI one runs with the compiled binary.

Developers can test it doing from the test folder doing:

  • pnpm moonwall test zombie_simple_template_upgrade_with_latest_releases if they are upgrading a non-frontier runtime or:
  • pnpm moonwall test zombie_frontier_template_upgrade_with_latest_releases if they are upgrading a frontier runtime

This should prevent developers from pushing runtimes that are not compatible with the latest release node (as it happened in the past)
CC @augustocollado

@girazoki girazoki added B0-silent Changes should not be mentioned in any release notes breaking Needs to be mentioned in breaking changes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit labels Aug 29, 2024
Copy link
Contributor

github-actions bot commented Aug 29, 2024

Coverage Report

(master)

@@                          Coverage Diff                          @@
##           master   girazoki-new-tools-for-developers      +/-   ##
=====================================================================
+ Coverage   67.20%                              67.55%   +0.35%     
  Files         262                                 262              
+ Lines       46906                               47490     +584     
=====================================================================
+ Hits        31519                               32080     +561     
+ Misses      15387                               15410      +23     
Files Changed Coverage
/pallets/registrar/src/lib.rs 88.50% (-0.36%) 🔽
/primitives/traits/src/lib.rs 68.18% (+2.96%) 🔼
/runtime/dancebox/src/tests/common/xcm/core_buyer_common.rs 86.45% (+0.05%) 🔼
/solo-chains/runtime/starlight/src/lib.rs 28.29% (+1.16%) 🔼
/solo-chains/runtime/starlight/src/tests/common/mod.rs 96.29% (+0.12%) 🔼

Coverage generated Wed Sep 4 21:22:39 UTC 2024

@Agusrodri
Copy link
Contributor

Agusrodri commented Sep 4, 2024

I checked locally and both jobs work fine! However, the Flashbox node was panicking with:

panicked at /home/gh-actions/.cargo/git/checkouts/polkadot-sdk-df3be1d6828443a1/be526b0/cumulus/pallets/parachain-system/src/lib.rs:140:13:
Relay chain block number needs to strictly increase between Parachain blocks!

This is because Flashbox config for parachain_system pallet was using RelayNumberStrictlyIncreases for CheckAssociatedRelayNumber type, and should use RelayNumberMonotonicallyIncreases instead.

Fixed in 89ac55a.

@girazoki girazoki merged commit 1e69d2a into master Sep 5, 2024
37 checks passed
@girazoki girazoki deleted the girazoki-new-tools-for-developers branch September 5, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes breaking Needs to be mentioned in breaking changes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants