-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[POC] Spawn embeded Container chain node on data preservers assignment #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanocryk
added
a0-pleasereview
Pull request needs code review.
B5-clientnoteworthy
Changes should be mentioned in any downstream projects' release notes
B7-runtimenoteworthy
Changes should be noted in any runtime-upgrade release notes
breaking
Needs to be mentioned in breaking changes
D5-nicetohaveaudit⚠️
PR contains trivial changes to logic that should be properly reviewed.
labels
Aug 27, 2024
tmpolaczyk
reviewed
Aug 27, 2024
tmpolaczyk
reviewed
Aug 27, 2024
Coverage Report@@ Coverage Diff @@
## master jeremy-spawn-cc-on-assignment +/- ##
=================================================================
- Coverage 67.55% 67.48% -0.07%
+ Files 262 264 +2
+ Lines 47490 47895 +405
=================================================================
+ Hits 32080 32321 +241
+ Misses 15410 15574 +164
|
tmpolaczyk
reviewed
Aug 27, 2024
girazoki
reviewed
Aug 28, 2024
girazoki
reviewed
Aug 28, 2024
girazoki
reviewed
Aug 28, 2024
girazoki
reviewed
Aug 28, 2024
girazoki
reviewed
Aug 28, 2024
girazoki
reviewed
Aug 28, 2024
girazoki
reviewed
Aug 28, 2024
tmpolaczyk
reviewed
Aug 28, 2024
tmpolaczyk
reviewed
Aug 28, 2024
Co-authored-by: tmpolaczyk <[email protected]>
tmpolaczyk
reviewed
Sep 3, 2024
girazoki
approved these changes
Sep 4, 2024
tmpolaczyk
reviewed
Sep 5, 2024
tmpolaczyk
reviewed
Sep 5, 2024
tmpolaczyk
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Don't forget to merge back master again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
a0-pleasereview
Pull request needs code review.
B5-clientnoteworthy
Changes should be mentioned in any downstream projects' release notes
B7-runtimenoteworthy
Changes should be noted in any runtime-upgrade release notes
breaking
Needs to be mentioned in breaking changes
D5-nicetohaveaudit⚠️
PR contains trivial changes to logic that should be properly reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the logic to detect assignments and spawn emebed container chain service corresponding to assignment.
This is a proof of concept and will need further work in later PRs:
simple
container chain node for now. Code incommand.rs
should be refactored out in a separate crate to be used byfrontier
container, which should support customizing the RPC (to support frontier RPC).Blocked by moondance-labs/dancekit#32 which adds an
OrchestratorChainInterface
function.