Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognise color tags and style them appropriately #26

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hikari-no-yume
Copy link
Contributor

@JosJuice
Copy link
Member

JosJuice commented Nov 3, 2020

If we're going to have a feature like this, I think our parsing rules should try to match the parsing rules of some playback program. The parsing rules you currently have don't actually match any playback program as far as I know, they just happen to match Soramimi and ECHO in one common case. (Soramimi only supports colors at the very beginning of a line as far as I know, and ECHO has additional ways of setting colors that aren't included in your rules. But I don't believe either of these programs have documented their color parsing rules, so perfectly matching them would be hard.)

Additionally, it should probably be possible to disable this feature, in case someone sets a color that makes the text hard to read. But that would have to wait until we have a settings window...

@hikari-no-yume
Copy link
Contributor Author

I pushed a new commit that matches Soramimi's parsing of color tags as precisely as possible without supporting subtitle=true, though I guess I didn't ensure they can only occur at the start of a line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants