Fix ModuleDB reporting wrong path when transient dependency cannot find the correct import

crates/moon/tests/test_cases/mod.rs

@@ -4406,6 +4406,19 @@ fn test_internal_package() {
     );
 }
 
+#[test]
+fn test_nonexistent_package() {
+    let dir = TestDir::new("nonexistent_package.in");
+    check(
+        get_err_stderr(&dir, ["check", "--sort-input"]),
+        expect![[r#"
+            error: $ROOT/main/moon.pkg.json: cannot import `username/hello/lib/b` in `username/hello/main`, no such package
+            $ROOT/main/moon.pkg.json: cannot import `username/hello/transient` in `username/hello/main`, no such package
+            $ROOT/pkg/transient/moon.pkg.json: cannot import `username/transient/lib/b` in `username/transient`, no such package
+        "#]],
+    );
+}
+
 #[test]
 fn mooncakes_io_smoke_test() {
     if std::env::var("CI").is_err() {

crates/moon/tests/test_cases/nonexistent_package.in/.gitignore

@@ -0,0 +1,2 @@
+target/
+.mooncakes/

crates/moon/tests/test_cases/nonexistent_package.in/README.md

@@ -0,0 +1 @@
+# username/hello

crates/moon/tests/test_cases/nonexistent_package.in/lib/hello.mbt

@@ -0,0 +1,3 @@
+pub fn hello() -> String {
+  "Hello, world!"
+}

crates/moon/tests/test_cases/nonexistent_package.in/lib/hello_wbtest.mbt

@@ -0,0 +1,5 @@
+test "hello" {
+  if hello() != "Hello, world!" {
+    return Err("hello() != \"Hello, world!\"")
+  }
+}

crates/moon/tests/test_cases/nonexistent_package.in/lib/moon.pkg.json

@@ -0,0 +1,3 @@
+{
+  "import": []
+}

crates/moon/tests/test_cases/nonexistent_package.in/main/main.mbt

@@ -0,0 +1,3 @@
+fn main {
+  println(@lib.hello())
+}

crates/moon/tests/test_cases/nonexistent_package.in/main/moon.pkg.json

@@ -0,0 +1,4 @@
+{
+  "is-main": true,
+  "import": ["username/hello/lib", "username/hello/lib/b", "username/hello/transient"]
+}

crates/moon/tests/test_cases/nonexistent_package.in/moon.mod.json

@@ -0,0 +1,10 @@
+{
+  "name": "username/hello",
+  "version": "0.1.0",
+  "deps": { "username/transient": { "path": "pkg/transient" } },
+  "readme": "README.md",
+  "repository": "",
+  "license": "",
+  "keywords": [],
+  "description": ""
+}

crates/moon/tests/test_cases/nonexistent_package.in/pkg/transient/lib/hello.mbt

@@ -0,0 +1,3 @@
+pub fn hello() -> String {
+  "Hello, world!"
+}

crates/moon/tests/test_cases/nonexistent_package.in/pkg/transient/lib/hello_wbtest.mbt

@@ -0,0 +1,5 @@
+test "hello" {
+  if hello() != "Hello, world!" {
+    return Err("hello() != \"Hello, world!\"")
+  }
+}

crates/moon/tests/test_cases/nonexistent_package.in/pkg/transient/lib/moon.pkg.json

@@ -0,0 +1,3 @@
+{
+  "import": []
+}

crates/moon/tests/test_cases/nonexistent_package.in/pkg/transient/moon.mod.json

@@ -0,0 +1,10 @@
+{
+  "name": "username/transient",
+  "version": "0.1.0",
+  "deps": {},
+  "readme": "README.md",
+  "repository": "",
+  "license": "",
+  "keywords": [],
+  "description": ""
+}

crates/moon/tests/test_cases/nonexistent_package.in/pkg/transient/moon.pkg.json

@@ -0,0 +1,3 @@
+{
+  "import": ["username/transient/lib/b"]
+}

crates/moonutil/src/module.rs

@@ -353,23 +353,15 @@ impl ModuleDB {
                 if !pkg.full_components().can_import(&item.full_components()) {
                     errors.push(format!(
                         "{}: cannot import internal package `{}` in `{}`",
-                        self.source_dir
-                            .join(self.source.as_ref().unwrap_or(&String::new()))
-                            .join(pkg.rel.fs_full_name())
-                            .join(MOON_PKG_JSON)
-                            .display(),
+                        pkg.root_path.join(MOON_PKG_JSON).display(),
                         imported,
                         pkg.full_name()
                     ))
                 }
                 if !self.packages.contains_key(&imported) {
                     errors.push(format!(
                         "{}: cannot import `{}` in `{}`, no such package",
-                        self.source_dir
-                            .join(self.source.as_ref().unwrap_or(&String::new()))
-                            .join(pkg.rel.fs_full_name())
-                            .join(MOON_PKG_JSON)
-                            .display(),
+                        pkg.root_path.join(MOON_PKG_JSON).display(),
                         imported,
                         pkg.full_name(),
                     ));