Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate Bytes::blit_from_string and Bytes::set_utf16_char #1278

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Yu-zh
Copy link
Collaborator

@Yu-zh Yu-zh commented Dec 2, 2024

This PR:

  1. deprecated Bytes::blit_from_string and Bytes::set_utf16_char
  2. refactored stringbuilder_buffer.mbt to use FixedArray[Byte] instead of Bytes
  3. Added FixedArray::reinterpreted_as_bytes and Bytes::reinterpreted_as_fixedarray for non-copy conversion between the two types.

@coveralls
Copy link
Collaborator

coveralls commented Dec 2, 2024

Pull Request Test Coverage Report for Build 4062

Details

  • 9 of 11 (81.82%) changed or added relevant lines in 5 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 80.287%

Changes Missing Coverage Covered Lines Changed/Added Lines %
buffer/buffer.mbt 2 4 50.0%
Files with Coverage Reduction New Missed Lines %
bytes/bytes.mbt 1 77.27%
builtin/bytes.mbt 6 52.63%
Totals Coverage Status
Change from base Build 4047: -0.1%
Covered Lines: 4370
Relevant Lines: 5443

💛 - Coveralls

@Yu-zh Yu-zh marked this pull request as draft December 2, 2024 07:30
@Yu-zh Yu-zh marked this pull request as ready for review December 3, 2024 01:27
builtin/builtin.mbti Outdated Show resolved Hide resolved
buffer/buffer.mbt Show resolved Hide resolved
builtin/bytes.mbt Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants