Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(buffer): to_unchecked_string method optional params #1246

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat(buffer): to_unchecked_string method optional params #1246

wants to merge 4 commits into from

Conversation

jetjinser
Copy link
Contributor

offset? : Int and length? : Int

@coveralls
Copy link
Collaborator

coveralls commented Nov 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 3952

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 79.765%
Files with Coverage Reduction New Missed Lines %
immut/sorted_set/immutable_set.mbt 6 88.15%
Totals Coverage Status
Change from base Build 3942: -0.1%
Covered Lines: 4352
Relevant Lines: 5456
💛 - Coveralls

@bobzhang
Copy link
Contributor

@jetjinser when do you need this API, @buffer.to_string? instead of @buffer.contents which return bytes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jetjinser @coveralls @bobzhang