Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pallet-xcm precompile to Moonbeam and Moonriver (transfer_assets_using_type_and_then extrinsic support) #2992

Merged
merged 5 commits into from
Oct 9, 2024

Conversation

Agusrodri
Copy link
Contributor

@Agusrodri Agusrodri commented Oct 5, 2024

What does it do?

This PR adds support for pallet-xcm precompile in both Moonbeam and Moonriver runtimes.

It also updates the moonkit's pin to include the most recent changes of the precompile, related to the new feature of using transfer_assets_using_type_and_then extrinsic through the precompile.

Related Moonkit PR

@Agusrodri Agusrodri marked this pull request as draft October 5, 2024 21:54
@Agusrodri Agusrodri changed the title Add pallet-xcm precompile to Moonbeam and Moonriver (transfer_assets_using_type_and_then extrinsic support) Add pallet-xcm precompile to Moonbeam and Moonriver (transfer_assets_using_type_and_then extrinsic support) Oct 5, 2024
Cargo.toml Outdated Show resolved Hide resolved
@Agusrodri Agusrodri added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. not-breaking Does not need to be mentioned in breaking changes labels Oct 5, 2024
Copy link
Contributor

github-actions bot commented Oct 5, 2024

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2292 KB (no changes) ✅

Moonbeam runtime: 2268 KB (no changes) ✅

Moonriver runtime: 2260 KB (no changes) ✅

Compared to latest release (runtime-3200)

Moonbase runtime: 2292 KB (+332 KB compared to latest release) ⚠️

Moonbeam runtime: 2268 KB (+344 KB compared to latest release) ⚠️

Moonriver runtime: 2260 KB (+336 KB compared to latest release) ⚠️

@Agusrodri Agusrodri marked this pull request as ready for review October 5, 2024 22:44
Copy link
Contributor

github-actions bot commented Oct 5, 2024

Coverage Report

@@                         Coverage Diff                          @@
##           master   agustin-xcm-transfer-assets-using     +/-   ##
====================================================================
  Coverage   79.12%                              79.12%   0.00%     
  Files         303                                 303             
+ Lines       88015                               88017      +2     
====================================================================
  Hits        69637                               69637             
+ Misses      18378                               18380      +2     
Files Changed Coverage
/runtime/moonbeam/src/lib.rs 46.62% (-0.08%) 🔽
/runtime/moonriver/src/lib.rs 46.85% (-0.07%) 🔽

Coverage generated Tue Oct 8 17:59:03 UTC 2024

@librelois librelois added the A8-mergeoncegreen Pull request is reviewed well. label Oct 7, 2024
@Agusrodri Agusrodri requested review from RomarQ and librelois October 8, 2024 17:14
Copy link
Contributor

@RomarQ RomarQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me

@RomarQ
Copy link
Contributor

RomarQ commented Oct 9, 2024

@Agusrodri Do we need to change any benchmarks?

@Agusrodri
Copy link
Contributor Author

@Agusrodri Do we need to change any benchmarks?

@RomarQ I don't think we need to change benchmarks itself. Although, I noticed that we don't have weights for transfer_assets_using_type_and_then pallet-xcm extrinsic. Should we generate them in this PR or shall we wait for the benchmarks PR that is done every release?

@RomarQ
Copy link
Contributor

RomarQ commented Oct 9, 2024

@Agusrodri Do we need to change any benchmarks?

@RomarQ I don't think we need to change benchmarks itself. Although, I noticed that we don't have weights for transfer_assets_using_type_and_then pallet-xcm extrinsic. Should we generate them in this PR or shall we wait for the benchmarks PR that is done every release?

transfer_assets_using_type_and_then uses weights from transfer_assets

@RomarQ RomarQ merged commit f9cde1f into master Oct 9, 2024
42 checks passed
@RomarQ RomarQ deleted the agustin-xcm-transfer-assets-using branch October 9, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A8-mergeoncegreen Pull request is reviewed well. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants