-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade polkadot-sdk to version 1.7.2 #2700
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomarQ
added
B5-clientnoteworthy
Changes should be mentioned in any downstream projects' release notes
B7-runtimenoteworthy
Changes should be noted in any runtime-upgrade release notes
D9-needsaudit👮
PR contains changes to fund-managing logic that should be properly reviewed and externally audited
breaking
Needs to be mentioned in breaking changes
labels
Mar 6, 2024
2 tasks
This reverts commit b3a4287.
Agusrodri
reviewed
Mar 19, 2024
Coverage Report@@ Coverage Diff @@
## master rq/update-polkadot-v1.7.2 +/- ##
=============================================================
- Coverage 73.44% 72.51% -0.93%
Files 229 229
+ Lines 70351 70565 +214
=============================================================
- Hits 51669 51164 -505
+ Misses 18682 19401 +719
|
Agusrodri
approved these changes
Mar 20, 2024
ahmadkaouk
reviewed
Mar 25, 2024
ahmadkaouk
approved these changes
Mar 26, 2024
librelois
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
B5-clientnoteworthy
Changes should be mentioned in any downstream projects' release notes
B7-runtimenoteworthy
Changes should be noted in any runtime-upgrade release notes
breaking
Needs to be mentioned in breaking changes
D9-needsaudit👮
PR contains changes to fund-managing logic that should be properly reviewed and externally audited
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
This PR updates polkadot-sdk dependencies to version 1.7.2.
What important points reviewers should know?
Polkadot-sdk version 1.7.2 includes XCMv4, which removes the
Multi
prefix in many places, changes some XCM syntax (examples below) and removesAbstract
variant fromAssetId
.New syntax for building locations and junctions
Now junctions are built using the following methods:
or
And they are matched like so:
This syntax is mandatory in v4, and has been also implemented for v2 and v3 for easier migration.
This was needed to make all sizes smaller.
Removed Abstract asset id
Now assets are just constructed as follows:
Is there something left for follow-up PRs?
NO
Are there relevant PRs or issues in other repositories (Polkadot-sdk, Frontier)?
Runtime API
Identity pallet:
XCM:
Message Queue
as DMP and XCMP dispatch queue paritytech/polkadot-sdk#1246reserve_transfer_assets
to support remote reserves paritytech/polkadot-sdk#1672RewardDestination
RewardDestination::Controller
paritytech/polkadot-sdk#2380RPC
Client
sc-block-builder
: RemoveBlockBuilderProvider
paritytech/polkadot-sdk#2099chain-spec
: getting ready for native-runtime-free world paritytech/polkadot-sdk#1256substrate-node:
NativeElseWasmExecutor
is no longer used paritytech/polkadot-sdk#2521 - ReplacesNativeElseWasmExecutor
in favor orWasmExecutor
. The runtime-overrides would not work anymore withNativeElseWasmExecutor
.cumulus-consensus-common: block import:
delayed_best_block
flag added paritytech/polkadot-sdk#2001Try-Runtime
Moonkit
What value does it bring to the blockchain users?