-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make shim-array.js less breaking world around #173
base: master
Are you sure you want to change the base?
Conversation
lgtm |
Can you rebase on master @a-x- ? |
done |
Some test still break I will check why. |
Need refactor to use internals if not extended. |
could you add an example? As I understand someone may keep native, say, Am I correct? |
@a-x- Sorry I really like to have that merge for fixing #196 but your changes break the tests.
No. What I propose is make sure collections internally use his Array functions if there have a difference with Native Array or use private functions if needed. |
@a-x- I cannot merge if test fails. to run test:
|
closes #169 collections breaks Array.from with Iterables