Merge pull request #134 from monsieurbiz/fix/space-into-query

Trim the query in request
monsieurbiz · Aug 17, 2022 · c4eb8e3 · c4eb8e3
2 parents 846cfa0 + 0cb9a72
commit c4eb8e3
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 10 deletions.
diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml
@@ -35,8 +35,8 @@ jobs:
 
       - name: Install symfony CLI
         run: |
-          curl https://get.symfony.com/cli/installer | bash
-          echo "${HOME}/.symfony/bin" >> $GITHUB_PATH
+          curl -1sLf 'https://dl.cloudsmith.io/public/symfony/stable/setup.deb.sh' | sudo -E bash
+          sudo apt install symfony-cli
 
       - uses: actions/cache@v1
         id: cache-composer

diff --git a/src/Search/Request/ProductRequest/InstantSearch.php b/src/Search/Request/ProductRequest/InstantSearch.php
@@ -57,8 +57,8 @@ public function getDocumentable(): DocumentableInterface
 
     public function getQuery(): Query
     {
-        if (null === $this->configuration || '' === $this->configuration->getQueryText()) {
-            throw new RuntimeException('missing query text');
+        if (null === $this->configuration) {
+            throw new RuntimeException('missing configuration');
         }
 
         $qb = new QueryBuilder();

diff --git a/src/Search/Request/ProductRequest/Search.php b/src/Search/Request/ProductRequest/Search.php
@@ -25,7 +25,6 @@
 use MonsieurBiz\SyliusSearchPlugin\Search\Request\RequestConfiguration;
 use MonsieurBiz\SyliusSearchPlugin\Search\Request\RequestInterface;
 use MonsieurBiz\SyliusSearchPlugin\Search\Request\Sorting\SorterRegistryInterface;
-use RuntimeException;
 use Sylius\Component\Registry\ServiceRegistryInterface;
 
 final class Search implements RequestInterface
@@ -87,10 +86,6 @@ public function setConfiguration(RequestConfiguration $configuration): void
 
     public function getQuery(): Query
     {
-        if ('' === $this->configuration->getQueryText()) {
-            throw new RuntimeException('missing query text');
-        }
-
         $qb = new QueryBuilder();
 
         $boolQuery = $qb->query()->bool();

diff --git a/src/Search/Request/RequestConfiguration.php b/src/Search/Request/RequestConfiguration.php
@@ -56,7 +56,7 @@ public function __construct(
 
     public function getQueryText(): string
     {
-        return $this->request->get('query', '');
+        return trim($this->request->get('query', ''));
     }
 
     public function getAppliedFilters(string $type = null): array