chore: sylius 1.13 compatibility #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @fred-dedi , I was looking for upgrading to Sylius 1.13 and found your PR. |
|
hi @chibani It looks like the github action tried to install sylius 1.13 with php 8.0 and failed.
|
|
PHP 8.0 support has been dropped with Sylius 1.13, so it can't install. |
|
@chibani yes i know that, that's why i tried to exclude it from the matrix but it did not work as intended |
|
Hi @fred-dedi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR adds sylius 1.13 compatibility.
I am not sure about deleted dev dependencies being really useful in the plugin, but it is compulsory to remove them as they conflicts with doctrine/dbal and psr/log requirements.