-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax package dependency requirements #557
Conversation
WeatherGod
commented
Aug 9, 2024
•
edited
Loading
edited
- Relax dependency requirements to allow newer versions.
- Gain numpy 2.x compatibility by fixing np.NaN to np.nan
Closes #535. Trying it out without pinning numpy to <2.0 as, technically, it didn't before. |
Just did a numpy 2.0 compatibility check with ruff, and there are some mistakes that looks like are easily fixable. |
Quality Gate passedIssues Measures |
This also supersedes #536. |
Reviewer's Guide by SourceryThis pull request focuses on relaxing package dependency requirements by replacing all instances of np.NaN with np.nan across multiple files. This change ensures consistency and compatibility with different versions of numpy. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @WeatherGod - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Thanks for the tidy-up for numpy, @WeatherGod |