proxy: Property get/set via CLR properties #66
Conversation
src/ExportObject.cs
Outdated
| break; | ||
| case "Get": | ||
| mi = pi.GetGetMethod (); | ||
| pc = TypeImplementer.GenGetCall(pi); |
There was a problem hiding this comment.
TODO: Cache the result of delegate generation. I used a dedicated class on my master branch for this but it seemed a bit overkill when I revisited the patch.
src/TypeImplementer.cs
Outdated
|
|
||
| return method_builder; | ||
| } | ||
| } |
There was a problem hiding this comment.
I needed this for avoiding implementation of property methods and quickly defining method override boilerplate - I avoided any changes elsewhere but it's identical to the block used for defining method overrides in the regular case of a declared interface method.
Move this pair of extensions to their own file?
| } catch (Exception e) { | ||
| raisedException = e; | ||
| } | ||
|
|
There was a problem hiding this comment.
In my master branch I had refactored this copy/paste into a function called IssueReply but I've avoided that change to try and keep the patch small.
arfbtwn
force-pushed
the
feature/properties
branch
from
edaceea
to
76d8b47
Compare
arfbtwn
force-pushed
the
feature/properties
branch
from
76d8b47
to
d752fa5
Compare
|
chance of a review, @garuma? |
Property Get/Set is handled by two additional functions in the BusObject
class, the IL is generated specifically for them.