Use <WindowsSdkPackageVersion> to set the SDK version
#3085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
changed the title
<WindowsSdkPackageVersion> as well<WindowsSdkPackageVersion> to set the SDK version
github-actions bot
pushed a commit
that referenced
this pull request
Nov 27, 2024
(cherry picked from commit aa42586)
mattleibow
added a commit
that referenced
this pull request
Nov 27, 2024
(cherry picked from commit aa42586) Co-authored-by: Matthew Leibowitz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
I think the SDK and/or VS updates have brought in some issue, but I think there is another way to do what we want.
We currently have this:
But that is assuming the framework references are added early and we run late. But, it appears something changed and now the values are either ignored or the items are added in a different place. This results in our adjustments being ignored.
There is another property
<WindowsSdkPackageVersion>that can be used and feels more official.I think in net6 something broke with the property so we had to do it via the framework references, but now it appears they fixed it and broke us.