feat: controller should only watch for UpdateEvents for VirtualServices whose spec changes #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es whose spec changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior
The controller watches for all changes to VirtualServices, and triggers reconciliation for relevant VirtualServiceMerges.
Proposed behavior
The controller doesn't necessarily need to watch for DeleteEvents, GenericEvents, and also UpdateEvents where the VirtualService spec has not changed.
The controller should limit itself to only watch for CreateEvents and UpdateEvents whose VirtualService spec has changed, in order not to trigger wasteful reconciliation cycles.
Tests
We are currently using this edited version of the controller in production, and everything works as expected.