fix: controller should list all virtualservicemerges, not just those in the same namespace #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior
The istio-virtualservice-merger controller watches for changes to VirtualServices.
For each VirtualService that changed, the controller triggers reconciliation for VirtualServiceMerges (that target the changed VirtualService) that are in the same namespace as the changed VirtualService.
This fails to account for VirtualServiceMerges deployed to a different namespace than its target VirtualService.
Ex)
Proposed behavior
For each changed VirtualService, the controller should trigger reconciliation for all VirtualServiceMerges (that target the changed VirtualService) regardless of the VirtualServiceMerge's namespace.
Again, this is because VirtualServiceMerges and their target VirtualServices can be deployed to different namespaces.
Tests
We are currently using this edited version of the controller in production, and everything works as expected.