Add support for findOneAndReplace #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findOneAndReplace is currently not supported. This is required since a change in mongoose (commit 0caeb6b2e8428cb56573b75212ddb7c186c2725d) swapped findOneAndUpdate with the overwrite option set to use findOneAndReplace which is not supported by mongoose-lean-getters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
findOneAndReplace is currently not supported. This is required since a change in mongoose (commit 0caeb6b2e8428cb56573b75212ddb7c186c2725d) swapped findOneAndUpdate with the overwrite option set to use findOneAndReplace which is not supported by mongoose-lean-getters.
Summary
When you use the overwrite option with findOneAndUpdate / findOneAndReplace the getters will not be applied to the schema.
Examples
We have a findOneAndReplace call with lean({getters: true}) specified. We have fields we want to convert from an objectId back to a string however the transfor is not applied.