fix: correctly get schema for each element of a discriminated array #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd do not attempt to get the schema for null/undefined docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also do not attempt to get the schema for null/undefined docs
Summary
After updating the package to the latest version (1.1.0) it started failing when an empty array contained discriminated documents. It would get the child schema using the array as the document instead of an element of the array so it would end up with an undefined schema.
With this change it now gets the schema for each document in the array (unless it is null/undefined) and will also not break if a schema has a discriminator mapping key but no discriminators object (which happens when the schema is configured the way it is in the test).
Examples
I have included a new test,
should work on schemas with discriminators in arrays, that failed before but passes now.