Allows connections to slave in replica sets #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows connections to slave in replica sets
Allows connections to slave in replica sets
esedor
added a commit
that referenced
this pull request
Aug 21, 2013
Allows connections to slave in replica sets - Nice, thanks!
|
While it removes the error, I'm not quite convinced that it is good enough: I have a SECONDARY_PREFERRED replication setup, and I manually turn on profiling for a single node when I want it. IMO, Dex should (have a switch to) simply turn on slaveOK when it notices that it's been pointed at a slave, and do it's thing on that machine only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added read_preference=pymongo.ReadPreference.PRIMARY_PREFERRED argument to all MongoClients.
Resolve Issue #7