Bug/187 track changes from embedded documents (NOT deeply nested) #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Startouf
force-pushed
the
bug/187-track-changes-from-embedded-documents
branch
from
89b9ce9 to
6a93b6e
Compare
|
For rubocop, |
Startouf
force-pushed
the
bug/187-track-changes-from-embedded-documents
branch
from
a16e94f to
4d96b45
Compare
Startouf
force-pushed
the
bug/187-track-changes-from-embedded-documents
branch
from
4d96b45 to
328ba98
Compare
|
@dblock build is green, waiting for your CR. PS : not really sure why the coverage decreased... maybe the paranoia field in the embedded document ? Should I test this too ? |
3 similar comments
dblock
reviewed
Jun 11, 2019
| @@ -1,5 +1,6 @@ | |||
| ### 0.8.2 (Next) | |||
|
|
|||
| * [#232](https://github.com/mongoid/mongoid-history/pull/232): Bug/187 track changes from embedded documents (not deeply nested) - [@Startouf](https://github.com/Startouf). | |||
There was a problem hiding this comment.
By convention we just do [#232], [#187]: ..., but I won't hold the CR for this.
|
I'm merging it. 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I finished a set of changes for tracking embeds_one changes from the child
It only works on the first level of a nested relationship (won't work for deeply nested relationships, I have added a "pending" test regarding this
I'm using the trick of "nested keys with dots" so that I can more easily make the difference between a nested document and just a field of type hash, so as to improve the tracking record
Fixes partially #187