DOP-4060 adds language selector to unified footer on docs' pages. #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 2, 2023 10:45
seungpark
requested changes
Oct 2, 2023
There was a problem hiding this comment.
@caesarbell can you verify what the end result of selecting eng/chinese on the dropdown should be? i'm not sure if we should be navigating them to a certain production page, or just changing the footer language, etc.
This is from the ticket A/C |
…ome PR feedback
added 2 commits
October 2, 2023 15:43
seungpark
approved these changes
Oct 3, 2023
Co-authored-by: rayangler <[email protected]>
rayangler
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stories/Links:
DOP-4060
Current Behavior:
current behavior
Staging Links:
staged with hiding language selector
staged with showing language selector
Notes:
This enables the language selector for the unified footer on all docs pages and points the href to the A/C of the ticket. This feature is also hidden behind a feature flag that is enabled only for non-prod env at this time.