DOP-5242 🐛 fixes the issue of the tab selector now rendering on mobile view #1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-frontend-stg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for docs-frontend-dotcomstg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
seungpark
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
Change lgtm! i think we forgot to add this property when allowing tabs to be directly in content
Would verify with design team for mobile/tablet views:
netlify.toml
Outdated
| @@ -6,7 +6,7 @@ publish = "public" | |||
| command = ". ./build.sh $REPO_NAME $PARSER_VERSION" | |||
|
|
|||
| [build.environment] | |||
| ORG_NAME = "mongodb" | |||
| REPO_NAME = "docs-landing" | |||
| ORG_NAME = "10gen" | |||
There was a problem hiding this comment.
do we still need this change? seems like it was used for staging
mmeigs
approved these changes
Jan 2, 2025
|
@seungpark @mmeigs good catch. |
…elector for tablet and mobile
seungpark
reviewed
Jan 6, 2025
rayangler
reviewed
Jan 6, 2025
…states, and fixes horizontal scrollbar issue
rayangler
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stories/Links:
DOP-5242
Current Behavior:
Docs Altas Prerequisites
Staging Links:
Put a link to your staging environment(s), if applicable
Notes:
This PR fixes the issue of the tab selector not rendering in the mobile view.
README updates