Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOP-5259: interactive method selector for offline docs #1331

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

seungpark
Copy link
Collaborator

@seungpark seungpark commented Dec 26, 2024

Stories/Links:

DOP-5259

Staging Links:

S3 file to download and verify that method selector works offline

online docs without OFFLINE_DOCS env flag for regression check

Notes:

  • The arrow indicator has been removed for offline method selectors as it needs some calculations based on selected index to get the position
  • On this Page headings will be handled separately as the content values are hidden in a React context

README updates

    • This PR introduces changes that should be reflected in the README, and I have made those updates.
    • This PR does not introduce changes that should be reflected in the README

Copy link

netlify bot commented Dec 26, 2024

Deploy Preview for docs-frontend-dotcomstg ready!

Name Link
🔨 Latest commit f0c5498
🔍 Latest deploy log https://app.netlify.com/sites/docs-frontend-dotcomstg/deploys/676d8c9e8d80300008f64a5c
😎 Deploy Preview https://deploy-preview-1331--docs-frontend-dotcomstg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 26, 2024

Deploy Preview for docs-frontend-stg ready!

Name Link
🔨 Latest commit f0c5498
🔍 Latest deploy log https://app.netlify.com/sites/docs-frontend-stg/deploys/676d8c9ed45e99000921a947
😎 Deploy Preview https://deploy-preview-1331--docs-frontend-stg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@seungpark seungpark marked this pull request as ready for review December 26, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant