DOP-5250: Support .ast filenames as pages #1327
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-frontend-stg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mmeigs
reviewed
Dec 16, 2024
Comment on lines
+158
to
+160
| const validPageExtensions = ['.txt', '.ast']; | ||
| const isValidPageExtension = validPageExtensions.some((ext) => filename.endsWith(ext)); | ||
| if (isValidPageExtension && !manifestMetadata.openapi_pages?.[key]) { |
There was a problem hiding this comment.
Just wondering if we need this! I thought we "translated" them in the parser to .txt extensions. Might have read this incorrectly though!
There was a problem hiding this comment.
I also thought that it would translate it to .txt extensions, but it turned out that that's specifically to support YAML files... I think I've found a way to get it working, but need to work through some bugs. Gonna close this PR for now while I investigate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stories/Links:
DOP-5250
Current Behavior:
N/A
Staging Links:
Java staging - .ast file
Java staging - .txt file (regression check)
Notes:
.astfilenames should be treated as full pages tooREADME updates