-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOP-5181: Upgrade Chatbot to 0.10.2 #1317
Conversation
✅ Deploy Preview for docs-frontend-dotcomstg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for docs-frontend-stg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for docs-frontend-dotcomprd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this pretty much lgtm in terms of functionality, but I did notice that the like/dislike icons seem off center. Do we know if this is an issue with the latest version, or is this only happening on the docs site for some reason (this doesn't currently happen on prod)?
EDIT: Ignore this. GH had some weird issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh boy, it's us. I wonder what in the world this was for... snooty/src/styles/mongodb-docs.css Line 388 in 77c54af
|
New staging link with style change: (annoyingly there are no specific classnames or ids for the chatbot modal - all auto-created) |
@@ -385,7 +385,8 @@ q:before { | |||
max-width: 970px; | |||
} | |||
} | |||
label { | |||
/* :not negation used to disallow these styles from affecting chatbot modal like/dislike buttons */ | |||
label:not([for*='-message-rating']) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. Whenever we have the time, we should investigate if the original CSS rule is still necessary. Thanks for looking into this!
Stories/Links:
DOP-5181
Current Behavior:
Landing
Staging Links:
Landing
Notes:
Updated Chatbot. Need to be on VPN to test on staging.
README updates