Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOP-5181: Upgrade Chatbot to 0.10.2 #1317

Merged
merged 2 commits into from
Dec 4, 2024
Merged

DOP-5181: Upgrade Chatbot to 0.10.2 #1317

merged 2 commits into from
Dec 4, 2024

Conversation

mmeigs
Copy link
Collaborator

@mmeigs mmeigs commented Dec 4, 2024

Stories/Links:

DOP-5181

Current Behavior:

Landing

Staging Links:

Landing

Notes:

Updated Chatbot. Need to be on VPN to test on staging.

README updates

    • This PR introduces changes that should be reflected in the README, and I have made those updates.
    • This PR does not introduce changes that should be reflected in the README

Copy link

netlify bot commented Dec 4, 2024

Deploy Preview for docs-frontend-dotcomstg ready!

Name Link
🔨 Latest commit 63481e0
🔍 Latest deploy log https://app.netlify.com/sites/docs-frontend-dotcomstg/deploys/6750ac0cf4e4640008920ee6
😎 Deploy Preview https://deploy-preview-1317--docs-frontend-dotcomstg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 4, 2024

Deploy Preview for docs-frontend-stg ready!

Name Link
🔨 Latest commit 63481e0
🔍 Latest deploy log https://app.netlify.com/sites/docs-frontend-stg/deploys/6750ac0cd2efbd0008484277
😎 Deploy Preview https://deploy-preview-1317--docs-frontend-stg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 4, 2024

Deploy Preview for docs-frontend-dotcomprd ready!

Name Link
🔨 Latest commit 63481e0
🔍 Latest deploy log https://app.netlify.com/sites/docs-frontend-dotcomprd/deploys/6750ac0c38a92f0008cd6169
😎 Deploy Preview https://deploy-preview-1317--docs-frontend-dotcomprd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mmeigs mmeigs requested review from seungpark and rayangler December 4, 2024 18:36
Copy link
Collaborator

@rayangler rayangler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this pretty much lgtm in terms of functionality, but I did notice that the like/dislike icons seem off center. Do we know if this is an issue with the latest version, or is this only happening on the docs site for some reason (this doesn't currently happen on prod)?

Screen Shot 2024-12-04 at 1 53 36 PM

EDIT: Ignore this. GH had some weird issue.

Copy link
Collaborator

@rayangler rayangler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this pretty much lgtm in terms of functionality, but I did notice that the like/dislike icons seem off center. Do we know if this is an issue with the latest version, or is this only happening on the docs site for some reason (this doesn't currently happen on prod)?

Screen Shot 2024-12-04 at 1 53 36 PM

@mmeigs
Copy link
Collaborator Author

mmeigs commented Dec 4, 2024

I think this pretty much lgtm in terms of functionality, but I did notice that the like/dislike icons seem off center. Do we know if this is an issue with the latest version, or is this only happening on the docs site for some reason (this doesn't currently happen on prod)?

Screen Shot 2024-12-04 at 1 53 36 PM

Oh boy, it's us. I wonder what in the world this was for...

@mmeigs
Copy link
Collaborator Author

mmeigs commented Dec 4, 2024

New staging link with style change:

(annoyingly there are no specific classnames or ids for the chatbot modal - all auto-created)

https://docs-mongodb-org-stg.s3.us-east-2.amazonaws.com/matt-example-sdk/java/matt.meigs/DOP-5181-chatbot/index.html

@mmeigs mmeigs requested a review from rayangler December 4, 2024 19:26
@@ -385,7 +385,8 @@ q:before {
max-width: 970px;
}
}
label {
/* :not negation used to disallow these styles from affecting chatbot modal like/dislike buttons */
label:not([for*='-message-rating']) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Whenever we have the time, we should investigate if the original CSS rule is still necessary. Thanks for looking into this!

@mmeigs mmeigs merged commit d5c9360 into main Dec 4, 2024
14 checks passed
@mmeigs mmeigs deleted the DOP-5181-chatbot branch December 4, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants