Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOP-5142: Remove border radius one dark mode images #1315

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

mmeigs
Copy link
Collaborator

@mmeigs mmeigs commented Dec 2, 2024

Stories/Links:

DOP-5142

Current Behavior:

ReadWriteConcern photo for example

Staging Links:

ReadWriteConcern in staging

Notes:

All dark mode images that were not hero images or on landing pages were being given a large border-radius style which could obscure some content. This removes that.

README updates

    • This PR introduces changes that should be reflected in the README, and I have made those updates.
    • This PR does not introduce changes that should be reflected in the README

Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for docs-frontend-dotcomstg failed. Why did it fail? →

Name Link
🔨 Latest commit 8270a0c
🔍 Latest deploy log https://app.netlify.com/sites/docs-frontend-dotcomstg/deploys/674f0f99129b010008810ccb

Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for docs-frontend-stg failed. Why did it fail? →

Name Link
🔨 Latest commit 8270a0c
🔍 Latest deploy log https://app.netlify.com/sites/docs-frontend-stg/deploys/674f0f996745b20008512264

Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for docs-frontend-dotcomprd failed. Why did it fail? →

Name Link
🔨 Latest commit 8270a0c
🔍 Latest deploy log https://app.netlify.com/sites/docs-frontend-dotcomprd/deploys/674f0f99b22687000942fea3

@mmeigs mmeigs requested a review from seungpark December 2, 2024 16:31
Copy link
Collaborator

@seungpark seungpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mmeigs mmeigs merged commit 77c54af into main Dec 3, 2024
2 of 14 checks passed
@mmeigs mmeigs deleted the DOP-5142-img-corners branch December 3, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants