Add filename lineno to class_eval and module_eval calls #4368

ivanovaleksey · 2016-12-22T15:18:26Z

No description provided.

ivanovaleksey · 2016-12-22T15:19:02Z

lib/mongoid/criteria/queryable/forwardable.rb

              def #{name}(*args, &block)
                #{receiver}.__send__(:#{name}, *args, &block)
              end
            SEL
          else
-            (class << self; self; end).class_eval <<-SEL


(class << self; self; end) does return singleton class of self, doesn't it?

estolfo · 2016-12-22T15:28:37Z

Hi @ivanovaleksey

Can you tell me what problem you are solving with this PR? Thanks

ivanovaleksey · 2016-12-22T15:40:27Z

Hi @estolfo

Initially I was looking for where is or method defined.
So I tried

or_method = User.method(:or)
or_method.source_location
# => ["(eval)", 1]

With this PR it would be

or_method.source_location
# ["/Users/aleksey/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/origin-2.3.0/lib/origin/forwardable.rb", 48]

Of course now I know where all these methods are defined but I thought it could be useful for others.

As you know in case of an error __FILE__ and __LINE__ in module_eval also show where really an error happened. I am not sure there could be much errors since these methods are not complicated but I thought it would not be superfluous.

ivanovaleksey · 2016-12-26T10:27:47Z

By the way there is issue for origin gem with the same suggestion.

estolfo · 2017-01-17T15:56:11Z

Thanks!

Add filename lineno to class_eval and module_eval calls

34b46da

ivanovaleksey commented Dec 22, 2016

View reviewed changes

ivanovaleksey closed this Dec 22, 2016

ivanovaleksey reopened this Dec 22, 2016

estolfo merged commit 67f0b97 into mongodb:master Jan 17, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add filename lineno to class_eval and module_eval calls #4368

Add filename lineno to class_eval and module_eval calls #4368

ivanovaleksey commented Dec 22, 2016

ivanovaleksey Dec 22, 2016

estolfo Jan 17, 2017

estolfo commented Dec 22, 2016

ivanovaleksey commented Dec 22, 2016 •

edited

Loading

ivanovaleksey commented Dec 26, 2016

estolfo commented Jan 17, 2017

Add filename lineno to class_eval and module_eval calls #4368

Add filename lineno to class_eval and module_eval calls #4368

Conversation

ivanovaleksey commented Dec 22, 2016

ivanovaleksey Dec 22, 2016

Choose a reason for hiding this comment

estolfo Jan 17, 2017

Choose a reason for hiding this comment

estolfo commented Dec 22, 2016

ivanovaleksey commented Dec 22, 2016 • edited Loading

ivanovaleksey commented Dec 26, 2016

estolfo commented Jan 17, 2017

ivanovaleksey commented Dec 22, 2016 •

edited

Loading