Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TOOLS-3697 Fix mongorestore’s import of indexes. #729

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

TOOLS-3697 Fix mongorestore’s import of indexes. #729

wants to merge 28 commits into from

Conversation

FGasper
Copy link
Contributor

@FGasper FGasper commented Oct 23, 2024 •
edited
Loading

This fixes a problem where mongorestore would errantly omit restoration of secondary _id indexes (e.g., hashed).

Ancillary changes:

  • ubi is updated to the same version that mongosync uses.
  • ConvertLegacyIndexKeys() is refactored to allow reuse of its internals without logging.

@FGasper FGasper marked this pull request as draft October 23, 2024 19:41
@FGasper FGasper requested review from jsflax and autarch October 24, 2024 20:34
@autarch
Copy link
Collaborator

autarch commented Oct 24, 2024 •
edited
Loading

This is still in draft. Did you mean to request reviewers?

@FGasper FGasper marked this pull request as ready for review October 24, 2024 23:48
@FGasper
Copy link
Contributor Author

FGasper commented Oct 25, 2024

@autarch Sorry, I was a bit premature. It’s ready for review now. Thanks!

autarch
autarch approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@autarch autarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jsflax
jsflax approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@jsflax jsflax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsflax jsflax jsflax approved these changes

@autarch autarch autarch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FGasper @autarch @jsflax