RUBY-3604 Fix multithread auth race condition

mongodb · Dec 23, 2024 · f145618 · f145618
1 parent 6e62448
commit f145618
Showing 1 changed file with 12 additions and 5 deletions.
diff --git a/lib/mongo/auth/credential_cache.rb b/lib/mongo/auth/credential_cache.rb
@@ -22,19 +22,24 @@ module Auth
     #
     # @api private
     module CredentialCache
+      MUTEX = Mutex.new
 
       class << self
         attr_reader :store
       end
 
       module_function def get(key)
-        @store ||= {}
-        @store[key]
+        MUTEX.synchronize do
+          @store ||= {}
+          @store[key]
+        end
       end
 
       module_function def set(key, value)
-        @store ||= {}
-        @store[key] = value
+        MUTEX.synchronize do
+          @store ||= {}
+          @store[key] = value
+        end
       end
 
       module_function def cache(key)
@@ -47,7 +52,9 @@ class << self
       end
 
       module_function def clear
-        @store = {}
+        MUTEX.synchronize do
+          @store = {}
+        end
       end
     end
   end