Skip to content

Commit

Permalink
RubyDNS is failing oddly with Ruby 2.7, so let's just skip it
Browse files Browse the repository at this point in the history
  • Loading branch information
jamis committed Oct 24, 2024
1 parent e608ebe commit 3179733
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 0 deletions.
2 changes: 2 additions & 0 deletions spec/integration/reconnect_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,8 @@
# thread.kill should've similarly failed, but it doesn't.
fails_on_jruby

minimum_mri_version '3.0.0'

it 'recreates SRV monitor' do
wait_for_discovery

Expand Down
2 changes: 2 additions & 0 deletions spec/integration/srv_monitoring_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,8 @@
# NotImplementedError: recvmsg_nonblock is not implemented
fails_on_jruby

minimum_mri_version '3.0.0'

around do |example|
# Speed up the tests by listening on the fake ports we are using.
done = false
Expand Down
10 changes: 10 additions & 0 deletions spec/support/constraints.rb
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,16 @@ def require_local_tls
end
end

def minimum_mri_version(version)
require_mri

before(:all) do
if RUBY_VERSION < version
skip "Ruby #{version} or greater is required"
end
end
end

def forbid_x509_auth
before(:all) do
skip 'X.509 auth not allowed' if SpecConfig.instance.x509_auth?
Expand Down

0 comments on commit 3179733

Please sign in to comment.