Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tests/specifications from c84488c to d1bdb68 #1490

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 21, 2024

Bumps tests/specifications from c84488c to d1bdb68.

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [tests/specifications](https://github.com/mongodb/specifications) from `c84488c` to `d1bdb68`.
- [Release notes](https://github.com/mongodb/specifications/releases)
- [Commits](mongodb/specifications@c84488c...d1bdb68)

---
updated-dependencies:
- dependency-name: tests/specifications
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team as a code owner October 21, 2024 06:13
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Oct 21, 2024
@dependabot dependabot bot requested a review from GromNaN October 21, 2024 06:13
@dependabot dependabot bot added the submodules Pull requests that update Submodules code label Oct 21, 2024
@alcaeus
Copy link
Member

alcaeus commented Oct 21, 2024

Note: changes for DRIVERS-2830 are tracked in PHPLIB-1490, but the implementation will happen in libmongoc.

@alcaeus alcaeus removed the request for review from GromNaN October 21, 2024 06:44
@jmikola
Copy link
Member

jmikola commented Oct 21, 2024

@alcaeus: there appear to be no functional changes in this PR. Would it make more sense to limit this to situations where actual test files are updated upstream, or is that not worth the effort? IIRC, there is a fixed interval for these update PRs.

@GromNaN
Copy link
Member

GromNaN commented Oct 21, 2024

If we close the PR as "not needed", this will pile-up in the diffs of the next PR. Meaning we will have to review it twice.

@alcaeus
Copy link
Member

alcaeus commented Oct 22, 2024

@alcaeus: there appear to be no functional changes in this PR. Would it make more sense to limit this to situations where actual test files are updated upstream, or is that not worth the effort? IIRC, there is a fixed interval for these update PRs.

The logic for updating submodules is pretty dumb - it can only update to newer commits (not just tags, which is why this is unfeasible for the libmongoc and libmongocrypt submodules in PHPC). Aside from that, we can not create any conditions for creating these PRs. The idea is that as long as tests are green and there are no relevant changes for us to make, we just merge the PR and wait for the next pull request.

@alcaeus alcaeus merged commit a57b67a into v1.x Oct 22, 2024
31 checks passed
@alcaeus alcaeus deleted the dependabot/submodules/tests/specifications-d1bdb68 branch October 22, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file submodules Pull requests that update Submodules code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants