Assert that the modifiers option is indeed deprecated #1451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
reviewed
Sep 25, 2024
alcaeus
force-pushed
the
assert-deprecation
branch
from
816f2ca to
1a42a40
Compare
GromNaN
approved these changes
Sep 25, 2024
This was referenced Sep 25, 2024
Merged
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an assertion that the
modifiersquery option is deprecated. While this commit is not necessary in 1.20 due to our usage of Symfony's PHPUnit Bridge which handles deprecations, when running phpunit directly the deprecation creates test output which causes a test failure in later versions. For this reason, I figured it's best to include this in 1.20.