Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPLIB-1529 Remove usage of deprecated event getServer #1415

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Sep 18, 2024

Fix PHPLIB-1529

The method CommandSucceededEvent::getServer() is deprecated by mongodb/mongo-php-driver#1652

It is not used since de3aaf8#diff-97711093784103ece28740e725cc6a5f44bba1a469d5dcb78ef94a85778b3549L473-L476

@GromNaN GromNaN requested a review from a team as a code owner September 18, 2024 08:58
@GromNaN GromNaN requested review from jmikola and alcaeus and removed request for jmikola September 18, 2024 08:58
@alcaeus
Copy link
Member

alcaeus commented Sep 18, 2024

We can target 1.20 with this change.

@GromNaN GromNaN changed the base branch from v1.x to v1.20 September 18, 2024 09:01
@GromNaN
Copy link
Member Author

GromNaN commented Sep 18, 2024

Target branch updated.

@GromNaN GromNaN enabled auto-merge (squash) September 18, 2024 09:20
@GromNaN GromNaN merged commit 45998dd into mongodb:v1.20 Sep 18, 2024
35 checks passed
This was referenced Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants