Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPLIB-1525 Removes dependency to Symfony PHPUnit bridge #1413

Merged
merged 5 commits into from
Sep 23, 2024
Merged

PHPLIB-1525 Removes dependency to Symfony PHPUnit bridge #1413

merged 5 commits into from
Sep 23, 2024

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Sep 17, 2024 •
edited
Loading

Fix PHPLIB-1525

The PHPUnit Bridge provides utilities to report legacy tests and usage of deprecated code and helpers for mocking native functions related to time, DNS and class existence.

We don't use any of this features.

The bridge also helps in maintaining custom constraints compatible with multiple versions of PHPUnit, due to type changes between versions 7, 8 and 9. This should longer be required as the Constraint class is fully typed.

drivers-atlas-testing will require an update:

GromNaN
GromNaN commented Sep 17, 2024
View reviewed changes
tests/GridFS/StreamWrapperFunctionalTest.php Outdated Show resolved Hide resolved
tests/ExamplesTest.php Outdated Show resolved Hide resolved
@GromNaN GromNaN marked this pull request as ready for review September 17, 2024 21:01
@GromNaN GromNaN requested a review from a team as a code owner September 17, 2024 21:01
@GromNaN GromNaN requested review from jmikola and removed request for jmikola September 17, 2024 21:01
alcaeus
alcaeus reviewed Sep 18, 2024
View reviewed changes
CONTRIBUTING.md Outdated

```console
$ SYMFONY_PHPUNIT_VERSION=8.5 vendor/bin/simple-phpunit
$ vendor/bin/phpunit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We document running the test suite with composer run test a few lines above (can't add a comment to the corresponding context line). We could document the direct way of calling the phpunit binary up there and remove this entire paragraph.

tests/ExamplesTest.php Outdated Show resolved Hide resolved
@GromNaN GromNaN force-pushed the PHPLIB-1525 branch 3 times, most recently from bc7cad4 to 3ce4d6a Compare September 18, 2024 20:50
@GromNaN GromNaN requested a review from alcaeus September 18, 2024 20:51
@GromNaN GromNaN force-pushed the PHPLIB-1525 branch 2 times, most recently from a8ace60 to 596c03d Compare September 23, 2024 08:30
@GromNaN GromNaN requested a review from alcaeus September 23, 2024 14:49
@GromNaN GromNaN merged commit 0960e1c into mongodb:v1.x Sep 23, 2024
31 checks passed
@GromNaN GromNaN deleted the PHPLIB-1525 branch September 23, 2024 17:13
@mongodb-php-bot mongodb-php-bot mentioned this pull request Sep 23, 2024
Merged
@GromNaN GromNaN mentioned this pull request Sep 23, 2024
Merged
alcaeus added a commit that referenced this pull request Sep 25, 2024
@alcaeus
Merge branch 'v1.x' into merge-v1.20-into-v1.x-1727194224833
f108ff6 
* v1.x: (90 commits)
  Merge v1.20 into v1.x (#1447)
  PHPLIB-1525 Removes dependency to Symfony PHPUnit bridge (#1413)
  Change deprecated assertObjectHasAttribute to assertObjectHasProperty (#1432)
  Performance: Keep collections and indexes between GridFS tests (#1421)
  Add final annotations to non-internal Operation classes (#1410)
  Fix types accepted by $round (#1401)
  Replace arrayHasKey with assertArrayHasKey in tests (#1403)
  PHPLIB-1514 Make data providers static (#1404)
  PHPLIB-1515 Replace assertObjectHasAttribute with assertObjectHasProperty (#1405)
  Restore Prose22_RangeExplicitEncryptionTest (#1400)
  Remove Prose22_RangeExplicitEncryptionTest that requires ext-mongodb < 1.20 (#1394)
  Use `match` instead of `switch` when a simple value is returned (#1393)
  Remove PHPUnit functions polyfill (#1395)
  Update branch names for GHA workflows (#1390)
  PHPLIB-1419 Encode Agg builder objects in Collection methods (#1383)
  PHPLIB-1420 Integrate query builder for non-aggregation APIs (#1385)
  Fix optional parameter declared before required parameter (#1384)
  PHPLIB-1505 Add driver option "builderEncoder" (#1382)
  Exclude rector.php from the artifact
  Check generated files are up-to-date
  ...
alcaeus added a commit that referenced this pull request Sep 25, 2024
@alcaeus
Merge branch 'v1.x' into merge-v1.20-into-v1.x-1727251978648
6428585 
* v1.x: (90 commits)
  Merge v1.20 into v1.x (#1447)
  PHPLIB-1525 Removes dependency to Symfony PHPUnit bridge (#1413)
  Change deprecated assertObjectHasAttribute to assertObjectHasProperty (#1432)
  Performance: Keep collections and indexes between GridFS tests (#1421)
  Add final annotations to non-internal Operation classes (#1410)
  Fix types accepted by $round (#1401)
  Replace arrayHasKey with assertArrayHasKey in tests (#1403)
  PHPLIB-1514 Make data providers static (#1404)
  PHPLIB-1515 Replace assertObjectHasAttribute with assertObjectHasProperty (#1405)
  Restore Prose22_RangeExplicitEncryptionTest (#1400)
  Remove Prose22_RangeExplicitEncryptionTest that requires ext-mongodb < 1.20 (#1394)
  Use `match` instead of `switch` when a simple value is returned (#1393)
  Remove PHPUnit functions polyfill (#1395)
  Update branch names for GHA workflows (#1390)
  PHPLIB-1419 Encode Agg builder objects in Collection methods (#1383)
  PHPLIB-1420 Integrate query builder for non-aggregation APIs (#1385)
  Fix optional parameter declared before required parameter (#1384)
  PHPLIB-1505 Add driver option "builderEncoder" (#1382)
  Exclude rector.php from the artifact
  Check generated files are up-to-date
  ...
alcaeus added a commit that referenced this pull request Sep 30, 2024
@alcaeus
Merge branch 'v1.x' into merge-v1.20-into-v1.x-1727445566295
7047c72 
* v1.x: (95 commits)
  PHPLIB-1369 Upgrade to PHPUnit 10 (#1412)
  Higher phpunit version required (#1463)
  Fix deprecations in tests (#1458)
  Deprecate functionality to be removed (#1441)
  Expect BulkWriteException (#1455)
  Merge v1.20 into v1.x (#1447)
  PHPLIB-1525 Removes dependency to Symfony PHPUnit bridge (#1413)
  Change deprecated assertObjectHasAttribute to assertObjectHasProperty (#1432)
  Performance: Keep collections and indexes between GridFS tests (#1421)
  Add final annotations to non-internal Operation classes (#1410)
  Fix types accepted by $round (#1401)
  Replace arrayHasKey with assertArrayHasKey in tests (#1403)
  PHPLIB-1514 Make data providers static (#1404)
  PHPLIB-1515 Replace assertObjectHasAttribute with assertObjectHasProperty (#1405)
  Restore Prose22_RangeExplicitEncryptionTest (#1400)
  Remove Prose22_RangeExplicitEncryptionTest that requires ext-mongodb < 1.20 (#1394)
  Use `match` instead of `switch` when a simple value is returned (#1393)
  Remove PHPUnit functions polyfill (#1395)
  Update branch names for GHA workflows (#1390)
  PHPLIB-1419 Encode Agg builder objects in Collection methods (#1383)
  ...
alcaeus added a commit that referenced this pull request Oct 16, 2024
@alcaeus
Merge branch 'v1.x' into merge-v1.20-into-v1.x-1729063519842
c0528b7 
* v1.x: (101 commits)
  PHPLIB-1541: Include specs repository as a submodule (#1429)
  PHPLIB-1548 Inherit `typeMap` option in `Collection::listSearchIndexes()` (#1482)
  Fix array shape for `Collection::listSearchIndex($options)` (#1480)
  PHPLIB-1545: Deprecate CreateCollection flags option and related constants (#1477)
  Fix junit logging (#1475)
  Deprecate typeMap on operations without meaningful result (#1473)
  PHPLIB-1369 Upgrade to PHPUnit 10 (#1412)
  Higher phpunit version required (#1463)
  Fix deprecations in tests (#1458)
  Deprecate functionality to be removed (#1441)
  Expect BulkWriteException (#1455)
  Merge v1.20 into v1.x (#1447)
  PHPLIB-1525 Removes dependency to Symfony PHPUnit bridge (#1413)
  Change deprecated assertObjectHasAttribute to assertObjectHasProperty (#1432)
  Performance: Keep collections and indexes between GridFS tests (#1421)
  Add final annotations to non-internal Operation classes (#1410)
  Fix types accepted by $round (#1401)
  Replace arrayHasKey with assertArrayHasKey in tests (#1403)
  PHPLIB-1514 Make data providers static (#1404)
  PHPLIB-1515 Replace assertObjectHasAttribute with assertObjectHasProperty (#1405)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcaeus alcaeus alcaeus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GromNaN @alcaeus