Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPLIB-953 Make internal classes and Operation classes final #1392

Merged
merged 4 commits into from
Sep 17, 2024
Merged

PHPLIB-953 Make internal classes and Operation classes final #1392

merged 4 commits into from
Sep 17, 2024

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Sep 12, 2024

@GromNaN GromNaN changed the base branch from v1.x to v2.x September 12, 2024 12:44
@GromNaN GromNaN marked this pull request as ready for review September 12, 2024 12:54
@GromNaN GromNaN requested a review from a team as a code owner September 12, 2024 12:54
@GromNaN GromNaN requested a review from jmikola September 12, 2024 12:54
@alcaeus
Copy link
Member

alcaeus commented Sep 13, 2024

This only includes a part of the classes in the Operation namespace. @jmikola should we make all of those classes internal and make those final that we don't extend for our own purposes?

@GromNaN
Copy link
Member Author

GromNaN commented Sep 13, 2024 •
edited
Loading

@internal I'm not sure because the operation classes can be used with explain. @final for sure, they are all composable.

@jmikola
Copy link
Member

jmikola commented Sep 16, 2024

I suppose all Operation classes can be @final if you want to go that route. Those that implement Explainable should not be considered internal, as @GromNaN stated.

jmikola
jmikola approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@jmikola jmikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll defer to you if this warrants some communication in UPGRADE-2.0.md.

@GromNaN GromNaN changed the title PHPLIB-953 Make internal classes final PHPLIB-953 Make internal classes and Operation classes final Sep 16, 2024
@alcaeus alcaeus enabled auto-merge (squash) September 17, 2024 06:57
@alcaeus alcaeus merged commit 368954a into mongodb:v2.x Sep 17, 2024
31 checks passed
This was referenced Sep 17, 2024
Merged
Merged
alcaeus added a commit that referenced this pull request Sep 25, 2024
@alcaeus
Merge branch 'v2.x' into merge-v1.x-into-v2.x-1727254882102
e94b259 
* v2.x:
  PHPLIB-954: Add return types to all methods (#1391)
  PHPLIB-797: Remove unused methods in UnsupportedException (#1436)
  Revert "Add final annotations to non-internal Operation classes (#1410)"
  PHPLIB-953 Make internal classes and Operation classes final (#1392)
  PHPLIB-1218 Remove deprecated fields from GridFS files (#1398)
alcaeus added a commit that referenced this pull request Sep 25, 2024
@alcaeus
Merge branch 'v2.x' into merge-v1.x-into-v2.x-1727254882102
a3f4b56 
* v2.x:
  PHPLIB-954: Add return types to all methods (#1391)
  PHPLIB-797: Remove unused methods in UnsupportedException (#1436)
  Revert "Add final annotations to non-internal Operation classes (#1410)"
  PHPLIB-953 Make internal classes and Operation classes final (#1392)
  PHPLIB-1218 Remove deprecated fields from GridFS files (#1398)
alcaeus added a commit that referenced this pull request Sep 25, 2024
@alcaeus
Merge branch 'v2.x' into merge-v1.x-into-v2.x-1727269627886
7c1758c 
* v2.x:
  PHPLIB-954: Add return types to all methods (#1391)
  PHPLIB-797: Remove unused methods in UnsupportedException (#1436)
  Revert "Add final annotations to non-internal Operation classes (#1410)"
  PHPLIB-953 Make internal classes and Operation classes final (#1392)
  PHPLIB-1218 Remove deprecated fields from GridFS files (#1398)
alcaeus added a commit that referenced this pull request Sep 30, 2024
@alcaeus
Merge branch 'v2.x' into merge-v1.x-into-v2.x-1727682441248
4030523 
* v2.x:
  PHPLIB-1518 `WriteResult::get*Count()` always return an int on acknowledged result (#1454)
  PHPLIB-954: Add return types to all methods (#1391)
  PHPLIB-797: Remove unused methods in UnsupportedException (#1436)
  Revert "Add final annotations to non-internal Operation classes (#1410)"
  PHPLIB-953 Make internal classes and Operation classes final (#1392)
  PHPLIB-1218 Remove deprecated fields from GridFS files (#1398)
alcaeus added a commit that referenced this pull request Oct 16, 2024
@alcaeus
Merge branch 'v2.x' into merge-v1.x-into-v2.x-1729063221979
bfc165a 
* v2.x:
  PHPLIB-1546 and PHPLIB-1159: Remove CreateCollection flags and autoIndexId options (#1478)
  PHPLIB-1227 Use void return types for operations without meaningful result document (#1468)
  Remove deprecated functionality (#1439)
  PHPLIB-1518 `WriteResult::get*Count()` always return an int on acknowledged result (#1454)
  PHPLIB-954: Add return types to all methods (#1391)
  PHPLIB-797: Remove unused methods in UnsupportedException (#1436)
  Revert "Add final annotations to non-internal Operation classes (#1410)"
  PHPLIB-953 Make internal classes and Operation classes final (#1392)
  PHPLIB-1218 Remove deprecated fields from GridFS files (#1398)
alcaeus added a commit that referenced this pull request Oct 29, 2024
@alcaeus
Merge branch 'v2.x' into merge-v1.x-into-v2.x-1730186279994
4248f52 
* v2.x:
  PHPLIB-1546 and PHPLIB-1159: Remove CreateCollection flags and autoIndexId options (#1478)
  PHPLIB-1227 Use void return types for operations without meaningful result document (#1468)
  Remove deprecated functionality (#1439)
  PHPLIB-1518 `WriteResult::get*Count()` always return an int on acknowledged result (#1454)
  PHPLIB-954: Add return types to all methods (#1391)
  PHPLIB-797: Remove unused methods in UnsupportedException (#1436)
  Revert "Add final annotations to non-internal Operation classes (#1410)"
  PHPLIB-953 Make internal classes and Operation classes final (#1392)
  PHPLIB-1218 Remove deprecated fields from GridFS files (#1398)
alcaeus added a commit that referenced this pull request Nov 4, 2024
@alcaeus
Merge branch 'v2.x' into merge-v1.x-into-v2.x-1730397444425
0870eaf 
* v2.x:
  Regenerate evergreen configuration (#1503)
  PHPLIB-1546 and PHPLIB-1159: Remove CreateCollection flags and autoIndexId options (#1478)
  PHPLIB-1227 Use void return types for operations without meaningful result document (#1468)
  Remove deprecated functionality (#1439)
  PHPLIB-1518 `WriteResult::get*Count()` always return an int on acknowledged result (#1454)
  PHPLIB-954: Add return types to all methods (#1391)
  PHPLIB-797: Remove unused methods in UnsupportedException (#1436)
  Revert "Add final annotations to non-internal Operation classes (#1410)"
  PHPLIB-953 Make internal classes and Operation classes final (#1392)
  PHPLIB-1218 Remove deprecated fields from GridFS files (#1398)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmikola jmikola jmikola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GromNaN @alcaeus @jmikola