PHPLIB-1309 Add addSubscriber/removeSubscriber to Client class to ease configuration #1195
Conversation
| * | ||
| * @see Manager::addSubscriber() | ||
| */ | ||
| final public function addSubscriber(Subscriber $subscriber): void |
There was a problem hiding this comment.
Please create documentation for the new methods. There should be enough prior art to copy content from other methods. Also, let's start at CHANGELOG-1.18.md file in the root directory of the project.
| Create a :phpclass:`MongoDB\\Driver\\Monitoring\\CommandSubscriber` that | ||
| logs all events: |
There was a problem hiding this comment.
I created this example as the example on Application Performance Monitoring (APM) seemed complicated to me
There was a problem hiding this comment.
We already have example code in the library for an APM subscriber.
It'd make more sense to create a tutorial page that includes APM code alongside surrounding documentation, as we've done for codecs and encryption. That sounds like a separate ticket, so you can just make a note there to come back and add a link to the tutorial to this method as a "See Also" link.
There was a problem hiding this comment.
I update the example to use the client method. Here is the ticket for the tutorial: https://jira.mongodb.org/browse/PHPLIB-1314
docs/includes/apiargs-MongoDBClient-method-addSubscriber-param.yaml
Outdated
Show resolved
Hide resolved
docs/includes/apiargs-MongoDBClient-method-removeSubscriber-param.yaml
Outdated
Show resolved
Hide resolved
docs/includes/apiargs-MongoDBClient-method-removeSubscriber-param.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Jeremy Mikola <[email protected]>
* master: PHPLIB-1323 Implement `unlink` for GridFS stream wrapper (mongodb#1206) PHPLIB-1330: Sync tests for failCommand errorLabels reqs (mongodb#1214) PHPLIB-1246: Test PHP 8.3 on Evergreen (mongodb#1213) PHPLIB-1324 Implement `rename` for GridFS stream wrapper (mongodb#1207) PHPLIB-1248 Add examples on GridFS (mongodb#1196) Deprecate setting GridFS disableMD5 to false explicitly (mongodb#1205) PHPLIB-1326: Use more permissive top-level runOnRequirements (mongodb#1210) PHPLIB-1206 Add bucket alises for context resolver using GridFS StreamWrapper (mongodb#1138) Bump actions/upload-artifact from 3 to 4 (mongodb#1208) PHPLIB-1275: Replace apiargs usage in docs with extracts (mongodb#1203) Fix title formatting in Client::removeSubscriber() docs (mongodb#1204) PHPLIB-1304: Pull mongohouse image from ECR repo (mongodb#1202) Fix evergreen failures (mongodb#1200) Enable workflows to run for GitHub Merge Queue (mongodb#1199) PHPLIB-1313 Ensure the GridFS stream is saved when the script ends (mongodb#1197) PHPLIB-1309 Add addSubscriber/removeSubscriber to Client class to ease configuration (mongodb#1195) Master is now 1.18-dev
Fix PHPLIB-1309
This need emerged while working on the MongoDB profiler for Symfony using monitoring features. Chaining method calls isn't possible in Symfony DI configuration. You have to use a "configurator".
I made the methods final so that we can change the signature in the future if necessary.