PHPLIB-1305 Support "codec" option in listSearchIndexes() #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
approved these changes
Nov 8, 2023
The codec is a new feature for v1.17. I don't see what alternative there would be to merging it into master before the 1.17.0 release. |
I wasn't sure if this was something we intended to fix in 1.17 or defer to 1.18. If 1.18, then it would only be merged to master after branching v1.17. |
|
I'm fine tossing it into 1.17 - however there should be at least a single test. For all I care, it could be a test passing an invalid codec, expecting an |
GromNaN
commented
Nov 9, 2023
| @@ -28,6 +28,8 @@ public function provideInvalidConstructorOptions(): array | |||
| $options[][] = ['batchSize' => $value]; | |||
| } | |||
|
|
|||
| $options[][] = ['codec' => 'foo']; | |||
alcaeus
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PHPLIB-1305
It's definitely not a place where I would expect a codec to be used, but why not.
I don't think we need to test all the options.