Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade rector/rector #1186

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Upgrade rector/rector #1186

merged 2 commits into from
Nov 13, 2023

Conversation

OskarStark
Copy link
Contributor

No description provided.

OskarStark
OskarStark commented Oct 21, 2023
View reviewed changes
src/Operation/Watch.php Outdated Show resolved Hide resolved
GromNaN
GromNaN requested changes Oct 21, 2023
View reviewed changes
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super. I'm glad to see that the bugs we were encountering have been fixed by rector.

Can you revert the IfIssetToCoalescingRector please.

src/Operation/Watch.php Outdated Show resolved Hide resolved
@OskarStark OskarStark requested a review from GromNaN October 22, 2023 07:56
@OskarStark
Copy link
Contributor Author

Rebased ✅

GromNaN
GromNaN reviewed Nov 13, 2023
View reviewed changes
rector.php Show resolved Hide resolved
@jmikola jmikola merged commit 8ee5560 into mongodb:master Nov 13, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GromNaN GromNaN GromNaN approved these changes

@jmikola jmikola jmikola left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OskarStark @jmikola @GromNaN