Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHPLIB-1254 Create Yaml for all operators and stages #1180
PHPLIB-1254 Create Yaml for all operators and stages #1180
Changes from 16 commits
6fe9809
204e88f
b3c6279
59f360c
64ee28e
05c5ee5
83aa77a
9a36d17
c0de34d
70f8671
38c7750
5733833
6faa7f8
27c9f21
502ed6b
3f175e7
d89d024
2129f88
06c5294
a5840c0
99e2266
636aa4a
5bc3cd8
bdfbcc5
c7bc14c
35dbd63
00b3cd3
dd28e4a
58fd4d0
13d29a8
e51b16f
c0790e0
960eaa4
120f530
57555b9
fee0df6
ad48be4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be reverted by PHPLIB-1268
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you come to a solution to still run PHPLIB against 7.4+ but limit the aggregation builder code to 8.1+?
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
numberFieldPath
required overfieldPath
since the code would expectResolvesToNumber
here? Do users still have the choice of passing an arbitrary field path as a string?Looking at this now, I can see how these might be annoying if users must use type in the query builder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a request from @alcaeus in the Technical Design doc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove when the scrape command is removed.