PHPLIB-1260: Revamp evergreen config #1179
Conversation
|
Note that the AWS without credentials already are already failing. I've created PHPLIB-1263 to investigate this separately. |
composer.json
Outdated
| @@ -13,7 +13,7 @@ | |||
| "php": "^7.4 || ^8.0", | |||
| "ext-hash": "*", | |||
| "ext-json": "*", | |||
| "ext-mongodb": "^1.17.0", | |||
| "ext-mongodb": "^1.16.0", | |||
There was a problem hiding this comment.
This was updated on-purpose by 1acfab0
There was a problem hiding this comment.
The commit was there for initial testing and has already been removed locally
This moves templates and generated files to separate folders and changes the loadbalanced tests to use its own topology instead of "sharded".
alcaeus
force-pushed
the
phplib-1260-revamp-evergreen-config
branch
from
7685b8e to
310ed92
Compare
| env: | ||
| MONGODB_VERSION: '7.0' | ||
| args: | ||
| - ${DRIVERS_TOOLS}/.evergreen/atlas/setup-atlas-cluster.sh |
There was a problem hiding this comment.
I noted this defaults MONGODB_VERSION to 6.0. Presumably 7.0 is required because this task group is used for search index testing (see: Setup).
| aws_key: ${aws_key} | ||
| aws_secret: ${aws_secret} | ||
| bucket: mciuploads | ||
| # TODO: Use separate folder for the library once it exists |
There was a problem hiding this comment.
Is this TODO item tracked anywhere?
| @@ -0,0 +1,37 @@ | |||
| #!/bin/sh | |||
| set -o errexit # Exit the script with error if any of the commands fail | |||
There was a problem hiding this comment.
| set -o errexit # Exit the script with error if any of the commands fail | |
| set -o errexit # Exit the script with error if any of the commands fail | |
| # Supported environment variables | |
| DEPENDENCIES=${DEPENDENCIES:-} # Specify "lowest" to prefer lowest dependencies | |
| COMPOSER_FLAGS="${COMPOSER_FLAGS:-}" # Optional, additional Composer flags |
I suppose you could omit COMPOSER_FLAGS since it's not used anywhere and really just set below when we process $DEPENDENCIES.
I know $PHP_PATH and $PROJECT_DIRECTORY are also referenced below, but $PROJECT_DIRECTORY is always just assumed. I'm not sure where $PHP_PATH comes from as that was originally exported by install-dependencies.sh but now handled by the locate PHP binaries function.
There was a problem hiding this comment.
$PHP_PATH is set through the add_expansions_to_env setting in the install composer function. locate PHP binaries is responsible for finding the path to PHP binaries and creates the evergreen expansion.
alcaeus
force-pushed
the
phplib-1260-revamp-evergreen-config
branch
from
cb666b7 to
f96762a
Compare
PHPLIB-1260
Similar to mongodb/mongo-php-driver#1473, this PR completely changes how we run evergreen builds.
Instead of running tests on various platforms, this only installs the extension on all supported platforms, which translates to testing
pecl install mongodbonce a stable version is out. We then run tests mostly on Debian 11 and Debian 9.2, although the Atlas and CSFLE tests run on RHEL 8.When starting a patch build for pull requests, only replica set configurations are tested automatically, while other tests can be enabled in the patch as required.