PHPLIB-1243: Renamed add_logger() and remove_logger() functions #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
changed the title
This renames the camelCase names introduced in 1acfab0 to snake_case, which is consistent with other functions.
GromNaN
approved these changes
Sep 26, 2023
jmikola
force-pushed
the
phplib-1143
branch
from
5384a14 to
8aa8366
Compare
alcaeus
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPLIB-1243
This renames the camelCase names introduced in 1acfab0 to snake_case, which is consistent with other functions.
Note: there's a typo in the branch name, but I correctly renamed the PR and commit to PHPLIB-1243.