Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Andreas Braun <[email protected]>
  • Loading branch information
GromNaN and alcaeus authored Sep 30, 2024
1 parent b99f4c1 commit 902762e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion UPGRADE-2.0.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ type changed to `void`. In case of an error, an exception is thrown.
* `MongoDB\Client`: `dropDatabase`
* `MongoDB\Collection`: `drop`, `dropIndex`, `dropIndexes`, `dropSearchIndex`, `rename`
* `MongoDB\Database`: `createCollection`, `drop`, `dropCollection`, `modifyCollection`, `renameCollection`
* `MongoDB\Database::createEncryptedCollection()` return the list of encrypted fields
* `MongoDB\Database::createEncryptedCollection()` returns the list of encrypted fields

If you still need to access the raw command result, you can use a `CommandSubscriber`.

Expand Down
2 changes: 1 addition & 1 deletion src/Operation/DropCollection.php
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ public function execute(Server $server): void
$server->executeWriteCommand($this->databaseName, $this->createCommand(), $this->createOptions());
} catch (CommandException $e) {
/* The server may return an error if the collection does not exist.
* Ignore the exception to make the drop operation is idempotent */
* Ignore the exception to make the drop operation idempotent */
if ($e->getCode() === self::ERROR_CODE_NAMESPACE_NOT_FOUND) {
return;
}
Expand Down

0 comments on commit 902762e

Please sign in to comment.